WIP: Creating the module #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cableman
force-pushed
the
develop
branch
12 times, most recently
from
714da60 to
f1a4c8e
Compare
cableman
force-pushed
the
develop
branch
8 times, most recently
from
3a51f97 to
11d06f0
Compare
jekuaitk
reviewed
May 1, 2024
| * Name of the plugin that started the exception. | ||
| * | ||
| * @return string | ||
| * Name of the plugin if given else "Unknown plugin". |
There was a problem hiding this comment.
Because NULL is not human friendly as most exception will to send to system logs
src/Plugin/AuditLogger/Loki.php
Outdated
| foreach ($curlOptions as $option) { | ||
| [$key] = explode(' =>', $option); | ||
| $key = trim($key); | ||
| if (!defined($key)) { |
There was a problem hiding this comment.
Maybe im not fully understanding this. Will this not accept any PHP constants? Is it just to filter out some invalid options?
There was a problem hiding this comment.
It is should check that it is one of: https://www.php.net/manual/en/function.curl-setopt.php
Have tried to update this part.
Co-authored-by: Jeppe Kuhlmann Andersen <[email protected]>
Co-authored-by: Jeppe Kuhlmann Andersen <[email protected]>
Co-authored-by: Jeppe Kuhlmann Andersen <[email protected]>
Co-authored-by: Jeppe Kuhlmann Andersen <[email protected]>
Co-authored-by: Jeppe Kuhlmann Andersen <[email protected]>
Co-authored-by: Jeppe Kuhlmann Andersen <[email protected]>
Co-authored-by: Jeppe Kuhlmann Andersen <[email protected]>
jekuaitk
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/?tab=timesheet#/tickets/showTicket/1064
Description
Audit module to log audit message to configurable backed using Drupal's plugin API.
Screenshot of the result
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
N/A